GTK2 docs patch

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

GTK2 docs patch

larcky
Hi
Please find attached a small documentation patch for the GTK2 module.
It reflects the changes Lance Dillon made to GTK2.TreeModel->iter_next() a while back and adds a note to TreeModel->get_value().
I've also bumped Chris Angelico's patch for GTK2.Window which seems to have got lost in the middle of another thread.

By the way, though iter_next() seems to work fine, I couldn't help noticing there are two variables called 'iter' in its implementation (src/post_modules/GTK2/source/gtktreemodel.pre: lines 150-165).  Wouldn't this normally cause some sort of name clash?

Thanks and best regards,
larcky

mydiff

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: GTK2 docs patch

Lance Dillon-2




----- Original Message ----

> From: larcky <[hidden email]>
> To: [hidden email]
> Sent: Sun, December 4, 2011 5:04:31 AM
> Subject: GTK2 docs patch
>
> Hi
> Please find attached a small documentation patch for the GTK2 module.
> It reflects the changes Lance Dillon made to GTK2.TreeModel->iter_next()  a
> while back and adds a note to TreeModel->get_value().
> I've also  bumped Chris Angelico's patch for GTK2.Window which seems to have
> got lost in  the middle of another thread.
>
> By the way, though iter_next() seems to  work fine, I couldn't help noticing
> there are two variables called 'iter' in  its implementation
> (src/post_modules/GTK2/source/gtktreemodel.pre: lines  150-165).  Wouldn't
> this normally cause some sort of name  clash?
>
> Thanks and best regards,
> larcky
>
> http://pike.1058338.n5.nabble.com/file/n5045949/mydiff mydiff
>
>

No, that is just the return value, but the return value is incorrect.  It
actually returns an int, not a GTK2.TreeIter.  


Your patch only seems to be updating the refdoc, not the actual source, and the
doc will be overwritten.  I will update the source.

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: GTK2 docs patch

larcky
Thanks :)
Lance Dillon-2 wrote
Your patch only seems to be updating the refdoc, not the actual source, and the
doc will be overwritten.  I will update the source.
Yes I did wonder about that.  I put the comments in the source originally but then 'make source' and 'make doc' didn't result in any changes.  Must have done something wrong earlier on.
Loading...